llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-backend-amdgpu Author: Alexander Richardson (arichardson) <details> <summary>Changes</summary> While we can only reason about the index/address, the G_PTRTOINT operations returns all representation bits, so we can't assume the remaining ones are all zeroes. This behaviour was clarified as part of the discussion in https://discourse.llvm.org/t/clarifiying-the-semantics-of-ptrtoint/83987/54. The LangRef semantics of ptrtoint being a full representation bitcast were documented in https://github.com/llvm/llvm-project/pull/139349. Fixes: https://github.com/llvm/llvm-project/issues/139598 --- Full diff: https://github.com/llvm/llvm-project/pull/139608.diff 2 Files Affected: - (modified) llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp (+3-1) - (modified) llvm/test/CodeGen/AMDGPU/GlobalISel/ptrtoint-ptrtoaddr-p8.ll (+14-27) ``````````diff diff --git a/llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp b/llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp index 12fe28b29e5c8..b7e0a43f2fb64 100644 --- a/llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp +++ b/llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp @@ -483,8 +483,10 @@ void GISelValueTracking::computeKnownBitsImpl(Register R, KnownBits &Known, if (Opcode == TargetOpcode::G_ASSERT_ZEXT) SrcBitWidth = MI.getOperand(2).getImm(); else { + // For G_PTRTOINT all representation bits are returned even though only + // the address bits can be reasoned about generically. SrcBitWidth = SrcTy.isPointer() - ? DL.getIndexSizeInBits(SrcTy.getAddressSpace()) + ? DL.getPointerSizeInBits(SrcTy.getAddressSpace()) : SrcTy.getSizeInBits(); } assert(SrcBitWidth && "SrcBitWidth can't be zero"); diff --git a/llvm/test/CodeGen/AMDGPU/GlobalISel/ptrtoint-ptrtoaddr-p8.ll b/llvm/test/CodeGen/AMDGPU/GlobalISel/ptrtoint-ptrtoaddr-p8.ll index 6722a55e8da92..d762d7728df36 100644 --- a/llvm/test/CodeGen/AMDGPU/GlobalISel/ptrtoint-ptrtoaddr-p8.ll +++ b/llvm/test/CodeGen/AMDGPU/GlobalISel/ptrtoint-ptrtoaddr-p8.ll @@ -79,9 +79,9 @@ define <2 x i64> @ptrtoaddr_vec(ptr addrspace(8) %ignored, <2 x ptr addrspace(8) ; GISEL: ; %bb.0: ; GISEL-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) ; GISEL-NEXT: v_mov_b32_e32 v0, v4 -; GISEL-NEXT: v_mov_b32_e32 v1, v5 +; GISEL-NEXT: v_and_b32_e32 v1, 0xffff, v5 +; GISEL-NEXT: v_and_b32_e32 v3, 0xffff, v9 ; GISEL-NEXT: v_mov_b32_e32 v2, v8 -; GISEL-NEXT: v_mov_b32_e32 v3, v9 ; GISEL-NEXT: s_setpc_b64 s[30:31] ; ; SDAG-LABEL: ptrtoaddr_vec: @@ -129,31 +129,18 @@ define i256 @ptrtoint_ext(ptr addrspace(8) %ignored, ptr addrspace(8) %ptr) { ;; FIXME: this is wrong for the GlobalISel case, we are removing the trunc: ;; https://github.com/llvm/llvm-project/issues/139598 define i256 @ptrtoaddr_ext(ptr addrspace(8) %ignored, ptr addrspace(8) %ptr) { -; GISEL-LABEL: ptrtoaddr_ext: -; GISEL: ; %bb.0: -; GISEL-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GISEL-NEXT: v_mov_b32_e32 v0, v4 -; GISEL-NEXT: v_mov_b32_e32 v1, v5 -; GISEL-NEXT: v_mov_b32_e32 v2, v6 -; GISEL-NEXT: v_mov_b32_e32 v3, v7 -; GISEL-NEXT: v_mov_b32_e32 v4, 0 -; GISEL-NEXT: v_mov_b32_e32 v5, 0 -; GISEL-NEXT: v_mov_b32_e32 v6, 0 -; GISEL-NEXT: v_mov_b32_e32 v7, 0 -; GISEL-NEXT: s_setpc_b64 s[30:31] -; -; SDAG-LABEL: ptrtoaddr_ext: -; SDAG: ; %bb.0: -; SDAG-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; SDAG-NEXT: v_mov_b32_e32 v0, v4 -; SDAG-NEXT: v_and_b32_e32 v1, 0xffff, v5 -; SDAG-NEXT: v_mov_b32_e32 v2, 0 -; SDAG-NEXT: v_mov_b32_e32 v3, 0 -; SDAG-NEXT: v_mov_b32_e32 v4, 0 -; SDAG-NEXT: v_mov_b32_e32 v5, 0 -; SDAG-NEXT: v_mov_b32_e32 v6, 0 -; SDAG-NEXT: v_mov_b32_e32 v7, 0 -; SDAG-NEXT: s_setpc_b64 s[30:31] +; CHECK-LABEL: ptrtoaddr_ext: +; CHECK: ; %bb.0: +; CHECK-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) +; CHECK-NEXT: v_mov_b32_e32 v0, v4 +; CHECK-NEXT: v_and_b32_e32 v1, 0xffff, v5 +; CHECK-NEXT: v_mov_b32_e32 v2, 0 +; CHECK-NEXT: v_mov_b32_e32 v3, 0 +; CHECK-NEXT: v_mov_b32_e32 v4, 0 +; CHECK-NEXT: v_mov_b32_e32 v5, 0 +; CHECK-NEXT: v_mov_b32_e32 v6, 0 +; CHECK-NEXT: v_mov_b32_e32 v7, 0 +; CHECK-NEXT: s_setpc_b64 s[30:31] %ret = ptrtoaddr ptr addrspace(8) %ptr to i256 ret i256 %ret } `````````` </details> https://github.com/llvm/llvm-project/pull/139608 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
