aaupov wrote:

> The code LGTM.
> 
> For practical applications, we sometimes use 3-way function splitting 
> resulting in code being broken into more than two partitions. In such case, 
> the most interesting metrics and score should be attached to non-cold 
> partitions. With "hot text" enabled, the corresponding address range of such 
> partition could be identified by [__hot_start, __hot_end).

I checked one such binary with .warm and .cold sections. We report them 
separately, e.g.
```
.text, 0xa200000, 0xb279c25, 81.8506, 72.3839, 0.7174
.text.warm, 0xb279c40, 0xb3777f1, 0.4027, 90.5474, 0.0044
.text.cold, 0xb377800, 0x18b84ca0, 0.3315, 1.6892, 0.0001
```

Do you mean we should bundle `.text` with `.text.warm` for reporting purposes?

https://github.com/llvm/llvm-project/pull/139193
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to