https://github.com/jmorse approved this pull request.
This all seems fine -- I guess the plumbing here has to get in without a test,
before then later real changes come in and can be tested.
The "Override" vs new-source-atom distinction seems a little clunky, although I
haven't read how it's used to get the full context. IMO it's worth putting
thought into a better name: can we pick an abstract name describing the purpose
("New key operation"?) where the override thing is just an implementation
feature?
https://github.com/llvm/llvm-project/pull/134632
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
