================ @@ -2586,22 +2590,21 @@ class VPMulAccumulateReductionRecipe : public VPReductionRecipe { VPValue *getVecOp1() const { return getOperand(2); } /// Return if this MulAcc recipe contains extend instructions. - bool isExtended() const { return ExtOp != Instruction::CastOps::CastOpsEnd; } + bool isExtended() const { ---------------- gbossu wrote:
It's just that in other places of the code, I think there is an assumption that `isExtended()` is equivalent to `ZExt || SExt` while there are other types of`CastOps` like "FP to Int". Please ignore me, this is a very pedantic comment ;) https://github.com/llvm/llvm-project/pull/136997 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits