llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) <details> <summary>Changes</summary> The PR139793 added handling of the Fortran-only "workshare" directive, however there are more such directives, e.g. "allocators". Use the genDirectiveLanguages function to detect non-C/C++ directives instead of enumerating them. --- Full diff: https://github.com/llvm/llvm-project/pull/139961.diff 3 Files Affected: - (modified) clang/lib/Parse/ParseOpenMP.cpp (+2-3) - (added) clang/test/OpenMP/openmp_non_c_directives.c (+12) - (removed) clang/test/OpenMP/openmp_workshare.c (-8) ``````````diff diff --git a/clang/lib/Parse/ParseOpenMP.cpp b/clang/lib/Parse/ParseOpenMP.cpp index c409409602e75..a53fd6b2964cb 100644 --- a/clang/lib/Parse/ParseOpenMP.cpp +++ b/clang/lib/Parse/ParseOpenMP.cpp @@ -2613,9 +2613,8 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( Diag(Tok, diag::err_omp_unknown_directive); return StmtError(); } - if (DKind == OMPD_workshare) { - // "workshare" is an executable, Fortran-only directive. Treat it - // as unknown. + if (!(getDirectiveLanguages(DKind) & SourceLanguage::C)) { + // Treat directives that are not allowed in C/C++ as unknown. DKind = OMPD_unknown; } diff --git a/clang/test/OpenMP/openmp_non_c_directives.c b/clang/test/OpenMP/openmp_non_c_directives.c new file mode 100644 index 0000000000000..844d7dad551bc --- /dev/null +++ b/clang/test/OpenMP/openmp_non_c_directives.c @@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -verify -fopenmp -ferror-limit 100 -o - %s + +// Test the reaction to some Fortran-only directives. + +void foo() { +#pragma omp allocators // expected-error {{expected an OpenMP directive}} +#pragma omp do // expected-error {{expected an OpenMP directive}} +#pragma omp end workshare // expected-error {{expected an OpenMP directive}} +#pragma omp parallel workshare // expected-warning {{extra tokens at the end of '#pragma omp parallel' are ignored}} +#pragma omp workshare // expected-error {{expected an OpenMP directive}} +} + diff --git a/clang/test/OpenMP/openmp_workshare.c b/clang/test/OpenMP/openmp_workshare.c deleted file mode 100644 index 0302eb19f9ef4..0000000000000 --- a/clang/test/OpenMP/openmp_workshare.c +++ /dev/null @@ -1,8 +0,0 @@ -// RUN: %clang_cc1 -verify -fopenmp -ferror-limit 100 -o - %s - -// Workshare is a Fortran-only directive. - -void foo() { -#pragma omp workshare // expected-error {{expected an OpenMP directive}} -} - `````````` </details> https://github.com/llvm/llvm-project/pull/139961 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
