github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h --
llvm/include/llvm/ProfileData/MemProf.h
llvm/include/llvm/ProfileData/MemProfYAML.h llvm/lib/ProfileData/MemProf.cpp
llvm/lib/ProfileData/MemProfReader.cpp
llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
llvm/unittests/ProfileData/MemProfTest.cpp
llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/ProfileData/MemProfReader.cpp
b/llvm/lib/ProfileData/MemProfReader.cpp
index aca534b0a..d6bc4fdf5 100644
--- a/llvm/lib/ProfileData/MemProfReader.cpp
+++ b/llvm/lib/ProfileData/MemProfReader.cpp
@@ -569,8 +569,7 @@ Error RawMemProfReader::symbolizeAndFilterStackFrames(
for (size_t I = 0, NumFrames = DI.getNumberOfFrames(); I < NumFrames;
I++) {
const auto &DIFrame = DI.getFrame(I);
- const uint64_t Guid =
- memprof::getGUID(DIFrame.FunctionName);
+ const uint64_t Guid = memprof::getGUID(DIFrame.FunctionName);
const Frame F(Guid, DIFrame.Line - DIFrame.StartLine, DIFrame.Column,
// Only the last entry is not an inlined location.
I != NumFrames - 1);
diff --git a/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp
b/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp
index 95828356b..2ed32c6ea 100644
--- a/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp
+++ b/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp
@@ -107,10 +107,9 @@ declare !dbg !19 void @_Z2f3v()
// locations.
EXPECT_THAT(
CallSites,
- ElementsAre(
- Pair(LineLocation(1, 3), memprof::getGUID("_Z2f1v")),
- Pair(LineLocation(2, 3), memprof::getGUID("_Z2f2v")),
- Pair(LineLocation(2, 9), memprof::getGUID("_Z2f3v"))));
+ ElementsAre(Pair(LineLocation(1, 3), memprof::getGUID("_Z2f1v")),
+ Pair(LineLocation(2, 3), memprof::getGUID("_Z2f2v")),
+ Pair(LineLocation(2, 9), memprof::getGUID("_Z2f3v"))));
}
TEST(MemProf, ExtractDirectCallsFromIRInline) {
@@ -206,25 +205,22 @@ declare !dbg !25 void @_Z2g2v() local_unnamed_addr
EXPECT_EQ(FooCallerGUID, memprof::getGUID("_Z3foov"));
EXPECT_THAT(
FooCallSites,
- ElementsAre(
- Pair(LineLocation(1, 3), memprof::getGUID("_ZL2f3v")),
- Pair(LineLocation(2, 9), memprof::getGUID("_ZL2g3v"))));
+ ElementsAre(Pair(LineLocation(1, 3), memprof::getGUID("_ZL2f3v")),
+ Pair(LineLocation(2, 9), memprof::getGUID("_ZL2g3v"))));
auto F2It = Calls.find(memprof::getGUID("_ZL2f2v"));
ASSERT_NE(F2It, Calls.end());
const auto &[F2CallerGUID, F2CallSites] = *F2It;
EXPECT_EQ(F2CallerGUID, memprof::getGUID("_ZL2f2v"));
- EXPECT_THAT(F2CallSites,
- ElementsAre(Pair(LineLocation(2, 3),
- memprof::getGUID("_Z2f1v"))));
+ EXPECT_THAT(F2CallSites, ElementsAre(Pair(LineLocation(2, 3),
+ memprof::getGUID("_Z2f1v"))));
auto F3It = Calls.find(memprof::getGUID("_ZL2f3v"));
ASSERT_NE(F3It, Calls.end());
const auto &[F3CallerGUID, F3CallSites] = *F3It;
EXPECT_EQ(F3CallerGUID, memprof::getGUID("_ZL2f3v"));
- EXPECT_THAT(F3CallSites,
- ElementsAre(Pair(LineLocation(1, 10),
- memprof::getGUID("_ZL2f2v"))));
+ EXPECT_THAT(F3CallSites, ElementsAre(Pair(LineLocation(1, 10),
+ memprof::getGUID("_ZL2f2v"))));
auto G3It = Calls.find(memprof::getGUID("_ZL2g3v"));
ASSERT_NE(G3It, Calls.end());
@@ -232,9 +228,8 @@ declare !dbg !25 void @_Z2g2v() local_unnamed_addr
EXPECT_EQ(G3CallerGUID, memprof::getGUID("_ZL2g3v"));
EXPECT_THAT(
G3CallSites,
- ElementsAre(
- Pair(LineLocation(1, 8), memprof::getGUID("_Z2g1v")),
- Pair(LineLocation(2, 3), memprof::getGUID("_Z2g2v"))));
+ ElementsAre(Pair(LineLocation(1, 8), memprof::getGUID("_Z2g1v")),
+ Pair(LineLocation(2, 3), memprof::getGUID("_Z2g2v"))));
}
TEST(MemProf, ExtractDirectCallsFromIRCallingNew) {
``````````
</details>
https://github.com/llvm/llvm-project/pull/140502
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
