github-actions[bot] wrote: <!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning: <details> <summary> You can test this locally with the following command: </summary> ``````````bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/ProfileData/IndexedMemProfData.h llvm/include/llvm/ProfileData/InstrProfWriter.h llvm/include/llvm/ProfileData/MemProf.h llvm/include/llvm/ProfileData/MemProfRadixTree.h llvm/include/llvm/ProfileData/MemProfReader.h llvm/lib/Bitcode/Writer/BitcodeWriter.cpp llvm/lib/ProfileData/InstrProfWriter.cpp llvm/lib/ProfileData/MemProf.cpp llvm/unittests/ProfileData/InstrProfTest.cpp llvm/unittests/ProfileData/MemProfTest.cpp llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp `````````` </details> <details> <summary> View the diff from clang-format here. </summary> ``````````diff diff --git a/llvm/include/llvm/ProfileData/IndexedMemProfData.h b/llvm/include/llvm/ProfileData/IndexedMemProfData.h index 94a162274..f33b160e0 100644 --- a/llvm/include/llvm/ProfileData/IndexedMemProfData.h +++ b/llvm/include/llvm/ProfileData/IndexedMemProfData.h @@ -69,15 +69,15 @@ private: // Compute a CallStackId for a given call stack. CallStackId hashCallStack(ArrayRef<FrameId> CS) const { - llvm::HashBuilder<llvm::TruncatedBLAKE3<8>, llvm::endianness::little> - HashBuilder; - for (FrameId F : CS) - HashBuilder.add(F); - llvm::BLAKE3Result<8> Hash = HashBuilder.final(); - CallStackId CSId; - std::memcpy(&CSId, Hash.data(), sizeof(Hash)); - return CSId; -} + llvm::HashBuilder<llvm::TruncatedBLAKE3<8>, llvm::endianness::little> + HashBuilder; + for (FrameId F : CS) + HashBuilder.add(F); + llvm::BLAKE3Result<8> Hash = HashBuilder.final(); + CallStackId CSId; + std::memcpy(&CSId, Hash.data(), sizeof(Hash)); + return CSId; + } }; } // namespace memprof diff --git a/llvm/include/llvm/ProfileData/InstrProfWriter.h b/llvm/include/llvm/ProfileData/InstrProfWriter.h index 16d2ef3fa..b72c901db 100644 --- a/llvm/include/llvm/ProfileData/InstrProfWriter.h +++ b/llvm/include/llvm/ProfileData/InstrProfWriter.h @@ -19,8 +19,8 @@ #include "llvm/ADT/StringMap.h" #include "llvm/IR/GlobalValue.h" #include "llvm/Object/BuildID.h" -#include "llvm/ProfileData/InstrProf.h" #include "llvm/ProfileData/IndexedMemProfData.h" +#include "llvm/ProfileData/InstrProf.h" #include "llvm/Support/Error.h" #include <cstdint> #include <memory> diff --git a/llvm/include/llvm/ProfileData/MemProfRadixTree.h b/llvm/include/llvm/ProfileData/MemProfRadixTree.h index 39f150c90..710721364 100644 --- a/llvm/include/llvm/ProfileData/MemProfRadixTree.h +++ b/llvm/include/llvm/ProfileData/MemProfRadixTree.h @@ -13,8 +13,8 @@ #ifndef LLVM_PROFILEDATA_MEMPROFRADIXTREE_H #define LLVM_PROFILEDATA_MEMPROFRADIXTREE_H -#include "llvm/ProfileData/MemProf.h" #include "llvm/ProfileData/IndexedMemProfData.h" +#include "llvm/ProfileData/MemProf.h" namespace llvm { namespace memprof { diff --git a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp index 427a161bc..f8d80c1fc 100644 --- a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp +++ b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp @@ -61,8 +61,8 @@ #include "llvm/MC/StringTableBuilder.h" #include "llvm/MC/TargetRegistry.h" #include "llvm/Object/IRSymtab.h" -#include "llvm/ProfileData/MemProf.h" #include "llvm/ProfileData/IndexedMemProfData.h" +#include "llvm/ProfileData/MemProf.h" #include "llvm/ProfileData/MemProfRadixTree.h" #include "llvm/Support/AtomicOrdering.h" #include "llvm/Support/Casting.h" diff --git a/llvm/unittests/ProfileData/InstrProfTest.cpp b/llvm/unittests/ProfileData/InstrProfTest.cpp index 6fc9b9074..dcdacb903 100644 --- a/llvm/unittests/ProfileData/InstrProfTest.cpp +++ b/llvm/unittests/ProfileData/InstrProfTest.cpp @@ -12,12 +12,12 @@ #include "llvm/IR/IRBuilder.h" #include "llvm/IR/LLVMContext.h" #include "llvm/IR/Module.h" +#include "llvm/ProfileData/IndexedMemProfData.h" #include "llvm/ProfileData/InstrProfReader.h" #include "llvm/ProfileData/InstrProfWriter.h" #include "llvm/ProfileData/MemProf.h" -#include "llvm/ProfileData/IndexedMemProfData.h" -#include "llvm/ProfileData/MemProfRadixTree.h" #include "llvm/ProfileData/MemProfData.inc" +#include "llvm/ProfileData/MemProfRadixTree.h" #include "llvm/Support/Compression.h" #include "llvm/Support/raw_ostream.h" #include "llvm/Testing/Support/Error.h" diff --git a/llvm/unittests/ProfileData/MemProfTest.cpp b/llvm/unittests/ProfileData/MemProfTest.cpp index 147f8813a..2113250e7 100644 --- a/llvm/unittests/ProfileData/MemProfTest.cpp +++ b/llvm/unittests/ProfileData/MemProfTest.cpp @@ -6,6 +6,7 @@ // //===----------------------------------------------------------------------===// +#include "llvm/ProfileData/MemProf.h" #include "llvm/ADT/DenseMap.h" #include "llvm/ADT/MapVector.h" #include "llvm/ADT/STLForwardCompat.h" @@ -13,11 +14,10 @@ #include "llvm/DebugInfo/Symbolize/SymbolizableModule.h" #include "llvm/IR/Value.h" #include "llvm/Object/ObjectFile.h" -#include "llvm/ProfileData/MemProf.h" #include "llvm/ProfileData/IndexedMemProfData.h" #include "llvm/ProfileData/MemProfData.inc" -#include "llvm/ProfileData/MemProfReader.h" #include "llvm/ProfileData/MemProfRadixTree.h" +#include "llvm/ProfileData/MemProfReader.h" #include "llvm/ProfileData/MemProfYAML.h" #include "llvm/Support/raw_ostream.h" #include "gmock/gmock.h" diff --git a/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp b/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp index 86b551b93..754819b33 100644 --- a/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp +++ b/llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp @@ -11,10 +11,10 @@ #include "llvm/IR/LLVMContext.h" #include "llvm/IR/Module.h" #include "llvm/Passes/PassBuilder.h" +#include "llvm/ProfileData/IndexedMemProfData.h" #include "llvm/ProfileData/InstrProfReader.h" #include "llvm/ProfileData/InstrProfWriter.h" #include "llvm/ProfileData/MemProf.h" -#include "llvm/ProfileData/IndexedMemProfData.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Testing/Support/Error.h" #include "llvm/Transforms/Instrumentation/MemProfiler.h" `````````` </details> https://github.com/llvm/llvm-project/pull/140503 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits