================
@@ -5849,6 +5852,7 @@ LValue CodeGenFunction::EmitObjCIsaExpr(const ObjCIsaExpr 
*E) {
 
 LValue CodeGenFunction::EmitCompoundAssignmentLValue(
                                             const CompoundAssignOperator *E) {
+  ApplyAtomGroup Grp(getDebugInfo());
----------------
OCHyams wrote:

> If I enter via a VisitBin##OP##Assign function from above I'll get an atom 
> group before calling EmitCompoundAssign,

Looks correct

> then get a second atom group here in EmitcompoundAssignmentLValue (which is 
> called by EmitCompoundAssign). I would have expected only one atom group to 
> be generated in that, is that wrong?

Looks wrong - `EmitCompoundAssign` calls `EmitCompoundAssignLValue` not 
`EmitcompoundAssignmentLValue`. The function names are annoyingly similar, this 
took a bit of head-scratching to re-figure out!

https://github.com/llvm/llvm-project/pull/134637
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to