================ @@ -172,7 +172,7 @@ function(add_compiler_rt_runtime name type) cmake_parse_arguments(LIB "" "PARENT_TARGET" - "OS;ARCHS;SOURCES;CFLAGS;LINK_FLAGS;DEFS;DEPS;LINK_LIBS;OBJECT_LIBS;ADDITIONAL_HEADERS;EXTENSIONS" + "OS;ARCHS;SOURCES;CFLAGS;LINK_FLAGS;DEFS;DEPS;LINK_LIBS;OBJECT_LIBS;ADDITIONAL_HEADERS;EXTENSIONS;C_STANDARD;CXX_STANDARD" ---------------- atrosinenko wrote:
`(C|CXX)_STANDARD` should probably go to `<one_value_keywords>` argument of [cmake_parse_arguments](https://cmake.org/cmake/help/v3.20/command/cmake_parse_arguments.html), same as `PARENT_TARGET`. [nit] The new options are not mentioned in the above comment (the description of `add_compiler_rt_runtime`). https://github.com/llvm/llvm-project/pull/133530 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits