================
@@ -582,6 +582,15 @@ static SmallVector<Value> getCollapsedIndices(RewriterBase 
&rewriter,
 
 namespace {
 
+/// Helper functon to return the index of the last dynamic dimension in 
`shape`.
----------------
newling wrote:

```suggestion
/// Helper functon to return the index of the last dynamic dimension in 
`shape`. or -1 if there are no dynamic dimensions
```
... if I understand correctly, although it might be static_cast<int64_t>(0ULL - 
1), not sure what that is

https://github.com/llvm/llvm-project/pull/142422
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to