DavidSpickett wrote: I reviewed a lot of the changes on main but was not involved in writing them or the work that they are being written for (Swift compiled to WASM, I believe).
The release note is the best place to start to understand it: > * LLDB can now set breakpoints, show backtraces, and display variables when > debugging Wasm with supported runtimes (WAMR and V8). We had *some* wasm support before but it was not usable as I understand it. These changes are not full support of wasm, but it will now do something useful with the runtimes mentioned. It's new features, but with a limited scope. So for backport risk, there are: * New tests. The nice thing is these tests are simulated targets so they run everywhere. On Linaro's Linux and Windows bots, there have been no problems so far. The new tests have no new dependencies either. * Some changes to internal DWARF handling functions. Debug information is well tested, so I don't consider this a risk. * Lots of new code specifically for WASM. This code is built unconditionally but does not bring in any new dependencies to LLDB. At runtime, this code is doing nothing unless you opt into connecting to a WASM target (in fact, due to a bug, the user has to type out the wasm plugin name, you can't accidentally do this). Is this a relatively large set of new features? Yes. Is it quite isolated? Yes. Does it change any user facing commands or LLDB API? No On that basis I'm ok with backporting this. If we want a second opinion, @labath did not review these changes on main, so might have a different take. https://github.com/llvm/llvm-project/pull/151559 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
