https://github.com/ldionne approved this pull request.
I reviewed the libc++ changes. I suggest we take the opportunity to make those more robust to future changes without really reducing their bug-finding power. I made my change suggestions such that you should be able to apply them as a batch with minimal effort on your side. My approval is only for the libc++ part of the changes and it assumes that you take my comments in batch. Thanks! https://github.com/llvm/llvm-project/pull/148014 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
