ro-i wrote: > 1. Can we remove the pass names added as tags? They don't actually add any > new information to the commit headline.
I think they do. I developed and submitted the PR to support inline-asm for amdgpu as two PRs so that it's not too large and easier to review. So, if I would call https://github.com/llvm/llvm-project/pull/149308 "[AMDGPU] Support callbr with inline-asm" instead of "[AMDGPU][FixIrreducible][UnifyLoopExits] Support callbr with inline-asm" this would be a lie since this PR here is needed, too. > 2. What does "basic" support signify? What is pending before we can call it > "complete" support? Thanks, I removed the "basic" since it's misleading. For me, "basic" = "inline-asm" and "complete" = "inline-asm + intrinsics", but that is in no way based on any commonly used definition. https://github.com/llvm/llvm-project/pull/152161 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
