================
@@ -1102,12 +1102,64 @@ struct DeferredStore {
 };
 } // namespace
 
+/// Check whether allocations for the given operation might potentially have to
+/// be done in device shared memory. That means we're compiling for a 
offloading
+/// target, the operation is an `omp::TargetOp` or nested inside of one and 
that
+/// target region represents a Generic (non-SPMD) kernel.
+///
+/// This represents a necessary but not sufficient set of conditions to use
+/// device shared memory in place of regular allocas. Depending on the 
variable,
+/// its uses or the associated OpenMP construct might also need to be taken 
into
----------------
bhandarkar-pranav wrote:

<nit>  - The 'or' in this sentence seems to be off. Did you mean "Depending on 
the variable and its uses, the associated OpenMP construct might need to be 
taken.."?

https://github.com/llvm/llvm-project/pull/150924
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to