https://github.com/bhandarkar-pranav commented:
Overall, the approach makes sense to me. thank you for the PR. Only big concern is @Meinersbur's comment on using a derived class of `CodeExtractor` instead of callbacks. Having said that callbacks are all over the place in `OMPIRBuilder`. https://github.com/llvm/llvm-project/pull/150925 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
