================ @@ -2030,32 +2031,68 @@ Value *llvm::addDiffRuntimeChecks( // Map to keep track of created compares, The key is the pair of operands for // the compare, to allow detecting and re-using redundant compares. DenseMap<std::pair<Value *, Value *>, Value *> SeenCompares; - for (const auto &[SrcStart, SinkStart, AccessSize, NeedsFreeze] : Checks) { + Value *AliasLaneMask = nullptr; + for (const auto &[SrcStart, SinkStart, AccessSize, NeedsFreeze, + WriteAfterRead] : Checks) { Type *Ty = SinkStart->getType(); - // Compute VF * IC * AccessSize. - auto *VFTimesICTimesSize = - ChkBuilder.CreateMul(GetVF(ChkBuilder, Ty->getScalarSizeInBits()), - ConstantInt::get(Ty, IC * AccessSize)); - Value *Diff = - Expander.expandCodeFor(SE.getMinusSCEV(SinkStart, SrcStart), Ty, Loc); - - // Check if the same compare has already been created earlier. In that case, - // there is no need to check it again. - Value *IsConflict = SeenCompares.lookup({Diff, VFTimesICTimesSize}); - if (IsConflict) - continue; + if (!VF.isScalar() && UseSafeEltsMask) { + Value *Sink = Expander.expandCodeFor(SinkStart, Ty, Loc); + Value *Src = Expander.expandCodeFor(SrcStart, Ty, Loc); ---------------- fhahn wrote:
It doesn't look like there's much re-use going on here. Better to have a separate function than complicate the logic here? https://github.com/llvm/llvm-project/pull/100579 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits