[llvm-branch-commits] [llvm] [DirectX] Add `split-section` to `llvm-objcopy` and implement it for `DXContainer` (PR #153265)

[Helena Kotas via llvm-branch-commits]

================
@@ -28,6 +52,31 @@ static Error handleArgs(const CommonConfig &Config, Object 
&Obj) {
       return Config.ToRemove.matches(P.Name);
     };
 
+  if (!Config.SplitSection.empty()) {
+    for (StringRef Flag : Config.SplitSection) {
+      StringRef SectionName;
+      StringRef FileName;
+      std::tie(SectionName, FileName) = Flag.split('=');
+
+      if (Error E = splitPartAsObject(SectionName, FileName,
+                                      Config.InputFilename, Obj))
+        return E;
+    }
+
+    RemovePred = [&Config, RemovePred](const Part &P) {
----------------
hekota wrote:

Reusing the same `RemovePred` here is a bit confusing.
```suggestion
    RemovePred = [&Config, OriginalRemovePred](const Part &P) {
```

https://github.com/llvm/llvm-project/pull/153265
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits