skatrak wrote: Thank you Michael for elaborating on this. Those are all fair points. I'm not really sure of how many other custom allocators we may end up needing, it might just end up being regular allocas vs device shared memory in the end. It's probably more likely we'd want to reuse the device shared memory allocator than creating a bunch of different custom allocators. So I think I'll work on refactoring this and see how well I can integrate it with everything else.
One problem with the current implementation is that the custom allocator is capturing `EntryBB` to basically override the alloca insertion point, a limitation related to the other concurrent discussion in this PR. So, in order to not make this dependent on that other potentially big set of changes, I'll have to store it in the `OutlineInfo` structure temporarily at least. https://github.com/llvm/llvm-project/pull/150925 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
