christopherbate wrote:

> The existing Standalone test already performs a nested build command

That test is using configure/build in a different build directory. Yes, it is 
nested in the existing one, but it is a new, temporary build directory.

Existing test does something like this:

- Parent CMake: SrcDir: `llvm-project/llvm`, BuildDir: `/path/to/build/`
- Subprocess CMake: SrcDir: `llvm-project/mlir/Examples/Standalone`, BuildDir: 
`/path/to/build/......./some-temprorary-test-dir`

Your new test (based on my understanding of the path expansions):

- Parent CMake: SrcDir: `llvm-project/llvm`, BuildDir: `/path/to/build/`
- Subprocess 1 CMake (llvm-build): SrcDir: `llvm-project/llvm`, BuildDir: 
`/path/to/build/`
- Subprocess 2 CMake (standalone): SrcDir: 
`llvm-project/mlir/Examples/Standalone`, BuildDir: 
`/path/to/build/......./some-temprorary-test-dir`

The fact that Subprocess 1 CMake and Parent CMake have identical build 
directories seems particularly problematic. 


https://github.com/llvm/llvm-project/pull/157944
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to