mstorsjo wrote:

> this doesn't build:
> 
> ```
>      78 |   if (getABIInfo().getCodeGenOpts().hasSEHExceptions())
>         |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
>   1 error generated.
> ```
> 
> please take a look

Oh, that's surprising.

It turns out that 76058c09071491fd097e85a0f5434b564dfad60b moved things around, 
and before that, we need to do things slightly differently.

With a diff like this on top, I can make it work:
```diff
diff --git a/clang/lib/CodeGen/TargetInfo.cpp b/clang/lib/CodeGen/TargetInfo.cpp
index 584b0d2e37f3..af711c14d4ed 100644
--- a/clang/lib/CodeGen/TargetInfo.cpp
+++ b/clang/lib/CodeGen/TargetInfo.cpp
@@ -75,7 +75,7 @@ TargetCodeGenInfo::~TargetCodeGenInfo() = default;
 // If someone can figure out a general rule for this, that would be great.
 // It's probably just doomed to be platform-dependent, though.
 unsigned TargetCodeGenInfo::getSizeOfUnwindException() const {
-  if (getABIInfo().getCodeGenOpts().hasSEHExceptions())
+  if (getABIInfo().getContext().getLangOpts().hasSEHExceptions())
     return getABIInfo().getDataLayout().getPointerSizeInBits() > 32 ? 64 : 48;
   // Verified for:
   //   x86-64     FreeBSD, Linux, Darwin
```

I updated the PR with that, which should fix things.

https://github.com/llvm/llvm-project/pull/163714
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to