SamTebbs33 wrote: > I may have missed it, but I don't see anything in the cost model work related > to the trunc/extend feature, just the addition of asserts. > > Could you please make that an independent PR?
In #147302 I was asked to make `IsMulAccValidAndClampRange` assert that the partial reduction cost is <= the base cost of the add + mul + extends, but had to change that to a return since the `add(mul(ext, const))` case was failing the assertion since it follows the same code path. This PR adds support for that `add(mul(ext, const))` case so it makes sense to return to the assertion in this PR. The PR is still small as it is anyway, and I was asked to re-add the assertion in this PR (https://github.com/llvm/llvm-project/pull/147302#discussion_r2426683086). https://github.com/llvm/llvm-project/pull/162503 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
