llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-compiler-rt-sanitizer Author: Aiden Grossman (boomanaiden154) <details> <summary>Changes</summary> These tests were already XFailed on Android, but are unresolved when running under the internal shell rather than failing due to missing file paths, which is likely the same reason they are xfailed. This does make it slightly worse if someone accidentally fixes these tests for Android without realizing it, but the alternative is likely fixing the functionality/test on Android. --- Full diff: https://github.com/llvm/llvm-project/pull/166639.diff 3 Files Affected: - (modified) compiler-rt/test/asan/TestCases/log-path_test.cpp (+1-2) - (modified) compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp (+2-2) - (modified) compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp (+1-1) ``````````diff diff --git a/compiler-rt/test/asan/TestCases/log-path_test.cpp b/compiler-rt/test/asan/TestCases/log-path_test.cpp index 6875d57c43cc0..22f077fb54680 100644 --- a/compiler-rt/test/asan/TestCases/log-path_test.cpp +++ b/compiler-rt/test/asan/TestCases/log-path_test.cpp @@ -1,6 +1,5 @@ // FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316 -// XFAIL: android -// UNSUPPORTED: ios +// UNSUPPORTED: ios, android // // The for loop in the backticks below requires bash. // REQUIRES: shell diff --git a/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp b/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp index 53166ccded390..f4781a7d47647 100644 --- a/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp +++ b/compiler-rt/test/asan/TestCases/verbose-log-path_test.cpp @@ -9,8 +9,8 @@ // RUN: FileCheck %s --check-prefix=CHECK-ERROR < %t-dir/asan.log.verbose-log-path_test-binary.* // FIXME: only FreeBSD, NetBSD and Linux have verbose log paths now. -// XFAIL: target={{.*windows-msvc.*}},android -// UNSUPPORTED: ios +// XFAIL: target={{.*windows-msvc.*}} +// UNSUPPORTED: ios, android #include <stdlib.h> #include <string.h> diff --git a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp index 6ba7025bf7578..68e76bb49f631 100644 --- a/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp +++ b/compiler-rt/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cpp @@ -7,7 +7,7 @@ // RUN: not %run %t %t-out && FileCheck < %t-out %s // REQUIRES: stable-runtime -// XFAIL: android && asan +// UNSUPPORTED: android #include <sanitizer/common_interface_defs.h> #include <stdio.h> `````````` </details> https://github.com/llvm/llvm-project/pull/166639 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
