https://github.com/stuij approved this pull request.

Thanks @atrosinenko, this is a nice cleanup.

Structurally it all looks fine, but could you add a comment to 
getBranchOpcodeForKey? And regarding the assert ("I-key expected"), could you 
be a little more descriptive. Say: "AArch64 PAC I-key expected".

https://github.com/llvm/llvm-project/pull/160901
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to