https://github.com/abhinavgaba commented:
The updated test looks good. Thanks for the changes! On an unrelated note, for future reference, to update a PR locally, it's usually better to do `git fetch origin main && git merge origin/main && git push origin HEAD`. Doing a `rebase` followed by a `git push --force` clobbers the history in the PR and breaks GitHub's "see changes since last review" feature. One scenario where a rebase + force-push can be useful is to update a branch while it still doesn't have a corresponding PR, or if the PR is in a draft stage and no reviewer has looked at it. https://github.com/llvm/llvm-project/pull/169367 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
