matthias-springer wrote:

Yes that's right. They are already getting special handling before this PR. 
Note that they are not handled by `RDVFinalCleanupList::blocks`.

I found the `RDVFinalCleanupList::values` confusing because there are already 
two handlers for values: `RDVFinalCleanupList::blocks` (block argument) and 
`RDVFinalCleanupList::results` (op result). Correct me if I'm wrong, but the 
only reason why `RDVFinalCleanupList::values` exists is because `blocks` cannot 
be used. The function op want to handle argument erasure by itself 
(`funcOp.eraseArguments`).


https://github.com/llvm/llvm-project/pull/173540
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to