================
@@ -0,0 +1,377 @@
+//===-- Internal utils for wctype conversion code - common ------*- C++ 
-*-===//
----------------
michaelrj-google wrote:

I'm generally against files named "utils", they frequently become dumping 
grounds for a random assortment of functions. All of these functions are used 
are used only in one other file, or aren't used at all. I'd recommend moving 
each function into the file that uses it, which will let you simplify this PR 
stack. If you need these functions in later PRs then they can be added later, 
or moved out of those files later.

https://github.com/llvm/llvm-project/pull/174798
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to