kosarev wrote: > > It doesn't seem like `--check-prefixies` is necessary. > > You're right that we're not using all the checks. My thought was that this > could be a convenient way to catch potential differences between the > assembler and disassembler output. We already have cases where certain values > are displayed in decimal and others in hexadecimal, so additional checks > might help us detect such inconsistencies early on.
I don't have an opinion here, but a couple more things to maybe take into account: the MC script currently doesn't catch cases where we would have to use the same check prefix for different outputs, in which case it just quietly leaves the test case without any checks at all. The other thing is the annoying constant oscillation between `-check-prefixes=` and `-check-prefix=` and different sets of prefixes as we update tests downstream. https://github.com/llvm/llvm-project/pull/177603 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
