tmsri wrote: On Fri, Feb 6, 2026, 8:59 PM Fangrui Song ***@***.***> wrote:
> ***@***.**** commented on this pull request. > ------------------------------ > > In lld/ELF/OutputSections.cpp > <https://github.com/llvm/llvm-project/pull/180304#discussion_r2777034973>: > > > @@ -303,8 +303,6 @@ static void nopInstrFill(Ctx &ctx, uint8_t *buf, size_t > > size) { > if (size == 0) > return; > unsigned i = 0; > - if (size == 0) > > Thanks for noticing this duplicate code from > https://reviews.llvm.org/D68065 . Do you happen to know if this feature > is actually still in use? Back when I was at Google, it had been sitting > unused for years, and I'd hate to keep carrying that technical debt if it's > no longer necessary. > Thanks for paying attention to technical debt. This is used at Google. Further, we are looking at using ML to learn code layout orderings where this feature is proving super useful. The primary reason I pushed for this feature. Hope this clarifies things. Sri > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/180304#pullrequestreview-3766276507>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AJJPQR4KJ6ZHGRD2ADP6SDL4KVWLNAVCNFSM6AAAAACUJID3TOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONRWGI3TMNJQG4> > . > You are receiving this because your review was requested.Message ID: > ***@***.***> > https://github.com/llvm/llvm-project/pull/180304 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
