https://github.com/skatrak updated https://github.com/llvm/llvm-project/pull/150923
>From b20d33b7e68e597b77b8282705ff8ae37389fb96 Mon Sep 17 00:00:00 2001 From: Sergio Afonso <[email protected]> Date: Tue, 8 Jul 2025 12:27:08 +0100 Subject: [PATCH 1/2] [OpenMP][OMPIRBuilder] Add device shared memory allocation support This patch adds the `__kmpc_alloc_shared` and `__kmpc_free_shared` DeviceRTL functions to the list of those the OMPIRBuilder is able to create. --- .../llvm/Frontend/OpenMP/OMPIRBuilder.h | 23 ++++++++++++++++ llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp | 27 +++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h b/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h index 9885ffc8b2065..681a144a09519 100644 --- a/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h +++ b/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h @@ -3187,6 +3187,29 @@ class OpenMPIRBuilder { LLVM_ABI CallInst *createOMPFree(const LocationDescription &Loc, Value *Addr, Value *Allocator, std::string Name = ""); + /// Create a runtime call for kmpc_alloc_shared. + /// + /// \param Loc The insert and source location description. + /// \param VarType Type of variable to be allocated. + /// \param Name Name of call Instruction. + /// + /// \returns CallInst to the kmpc_alloc_shared call. + LLVM_ABI CallInst *createOMPAllocShared(const LocationDescription &Loc, + Type *VarType, + const Twine &Name = Twine("")); + + /// Create a runtime call for kmpc_free_shared. + /// + /// \param Loc The insert and source location description. + /// \param Addr Value obtained from the corresponding kmpc_alloc_shared call. + /// \param VarType Type of variable to be freed. + /// \param Name Name of call Instruction. + /// + /// \returns CallInst to the kmpc_free_shared call. + LLVM_ABI CallInst *createOMPFreeShared(const LocationDescription &Loc, + Value *Addr, Type *VarType, + const Twine &Name = Twine("")); + /// Create a runtime call for kmpc_threadprivate_cached /// /// \param Loc The insert and source location description. diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp index 728e1c92d13f8..9fc7019b89611 100644 --- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp +++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp @@ -7593,6 +7593,33 @@ CallInst *OpenMPIRBuilder::createOMPFree(const LocationDescription &Loc, return createRuntimeFunctionCall(Fn, Args, Name); } +CallInst *OpenMPIRBuilder::createOMPAllocShared(const LocationDescription &Loc, + Type *VarType, + const Twine &Name) { + IRBuilder<>::InsertPointGuard IPG(Builder); + updateToLocation(Loc); + + const DataLayout &DL = M.getDataLayout(); + Value *Args[] = {Builder.getInt64(DL.getTypeStoreSize(VarType))}; + Function *Fn = getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_alloc_shared); + CallInst *Call = Builder.CreateCall(Fn, Args, Name); + Call->addRetAttr( + Attribute::getWithAlignment(M.getContext(), DL.getPrefTypeAlign(Int64))); + return Call; +} + +CallInst *OpenMPIRBuilder::createOMPFreeShared(const LocationDescription &Loc, + Value *Addr, Type *VarType, + const Twine &Name) { + IRBuilder<>::InsertPointGuard IPG(Builder); + updateToLocation(Loc); + + Value *Args[] = { + Addr, Builder.getInt64(M.getDataLayout().getTypeStoreSize(VarType))}; + Function *Fn = getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_free_shared); + return Builder.CreateCall(Fn, Args, Name); +} + CallInst *OpenMPIRBuilder::createOMPInteropInit( const LocationDescription &Loc, Value *InteropVar, omp::OMPInteropType InteropType, Value *Device, Value *NumDependences, >From 16d002e2761250bd109f7449fc2e3f9636eec986 Mon Sep 17 00:00:00 2001 From: Sergio Afonso <[email protected]> Date: Wed, 11 Feb 2026 15:53:35 +0000 Subject: [PATCH 2/2] address review comments --- llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp index 9fc7019b89611..afe86030f00f8 100644 --- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp +++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp @@ -7600,7 +7600,7 @@ CallInst *OpenMPIRBuilder::createOMPAllocShared(const LocationDescription &Loc, updateToLocation(Loc); const DataLayout &DL = M.getDataLayout(); - Value *Args[] = {Builder.getInt64(DL.getTypeStoreSize(VarType))}; + Value *Args[] = {Builder.getInt64(DL.getTypeAllocSize(VarType))}; Function *Fn = getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_alloc_shared); CallInst *Call = Builder.CreateCall(Fn, Args, Name); Call->addRetAttr( @@ -7615,7 +7615,7 @@ CallInst *OpenMPIRBuilder::createOMPFreeShared(const LocationDescription &Loc, updateToLocation(Loc); Value *Args[] = { - Addr, Builder.getInt64(M.getDataLayout().getTypeStoreSize(VarType))}; + Addr, Builder.getInt64(M.getDataLayout().getTypeAllocSize(VarType))}; Function *Fn = getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_free_shared); return Builder.CreateCall(Fn, Args, Name); } _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
