AaronBallman wrote: > AFAIK, this shouldn't be an ABI break, since this is simply modifying the > implementation of some functions defined in a `.cpp` file (it doesn't touch, > e.g., any interfaces or struct layouts). It's strictly on the library side of > the ABI boundary. > > Does that address your concern? From your comment I can't quite tell if > you're asking about just ABI or also the potential behavior changes in > downstream checks.
It's a bit of both; we don't want backported changes to change ABI because we want plugins compiled against 22.x to still link for all values of `x`. But (e.g.) clang-tidy also supports plugins and so changing the AST matcher behavior means it may link but behave in a surprising manner. On balance, I *think* this is safe to backport because this is such a specific change, but if a release manager or someone else has concerns, I think it's also fine to not backport (nothing seems to be on fire, at least unless I've missed something). https://github.com/llvm/llvm-project/pull/184039 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
