llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-llvm-transforms Author: Aiden Grossman (boomanaiden154) <details> <summary>Changes</summary> pgo-memop-opt has previously validated VP metadata and bailed if it runs into duplicate values in the VP metadata. VP metadata values will soon be deduplicated at construction, making this no longer necessary, and will also cause this test to fail, so drop it. Keep the verification/deduplication pgo-memop-opt for now to avoid leaving main in a broken state. --- Full diff: https://github.com/llvm/llvm-project/pull/197615.diff 2 Files Affected: - (removed) llvm/test/Transforms/PGOProfile/Inputs/consecutive-zeros.proftext (-47) - (removed) llvm/test/Transforms/PGOProfile/consecutive-zeros.ll (-58) ``````````diff diff --git a/llvm/test/Transforms/PGOProfile/Inputs/consecutive-zeros.proftext b/llvm/test/Transforms/PGOProfile/Inputs/consecutive-zeros.proftext deleted file mode 100644 index 93211cd9b0793..0000000000000 --- a/llvm/test/Transforms/PGOProfile/Inputs/consecutive-zeros.proftext +++ /dev/null @@ -1,47 +0,0 @@ -# IR level Instrumentation Flag -:ir -foo -# Func Hash: -687116424982578944 -# Num Counters: -3 -# Counter Values: -523 -20 -1 -# Num Value Kinds: -1 -# ValueKind = IPVK_MemOPSize: -1 -# NumValueSites: -3 -9 -0:99 -0:88 -3:77 -9:72 -4:66 -5:55 -6:44 -7:33 -8:22 -9 -7:33 -2:88 -9:72 -4:66 -1:99 -5:55 -6:44 -3:77 -8:22 -9 -7:33 -2:88 -9:72 -4:66 -1:99 -5:55 -6:44 -3:77 -8:22 diff --git a/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll b/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll deleted file mode 100644 index 014f95fd8bec6..0000000000000 --- a/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll +++ /dev/null @@ -1,58 +0,0 @@ -; RUN: llvm-profdata merge %S/Inputs/consecutive-zeros.proftext -o %t.profdata -; RUN: opt < %s -passes=pgo-instr-use,pgo-memop-opt -pgo-memop-count-threshold=0 -pgo-memop-percent-threshold=0 -pgo-test-profile-file=%t.profdata -S 2>&1 | FileCheck %s - -target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" -target triple = "x86_64-unknown-linux-gnu" - -define void @foo(ptr %dst, ptr %src, ptr %a, i32 %n) { -; CHECK: warning: Invalid Profile -entry: - br label %for.cond - -for.cond: - %i.0 = phi i32 [ 0, %entry ], [ %inc5, %for.inc4 ] - %cmp = icmp slt i32 %i.0, %n - br i1 %cmp, label %for.body, label %for.end6 - -for.body: - br label %for.cond1 - -for.cond1: - %j.0 = phi i32 [ 0, %for.body ], [ %inc, %for.inc ] - %idx.ext = sext i32 %i.0 to i64 - %add.ptr = getelementptr inbounds i32, ptr %a, i64 %idx.ext - %0 = load i32, ptr %add.ptr, align 4 - %cmp2 = icmp slt i32 %j.0, %0 - br i1 %cmp2, label %for.body3, label %for.end - -for.body3: - %add = add nsw i32 %i.0, 1 - %conv = sext i32 %add to i64 - call void @llvm.memcpy.p0.p0.i64(ptr %dst, ptr %src, i64 %conv, i1 false) - %memcmp = call i32 @memcmp(ptr %dst, ptr %src, i64 %conv) - %bcmp = call i32 @bcmp(ptr %dst, ptr %src, i64 %conv) - br label %for.inc - -for.inc: - %inc = add nsw i32 %j.0, 1 - br label %for.cond1 - -for.end: - br label %for.inc4 - -for.inc4: - %inc5 = add nsw i32 %i.0, 1 - br label %for.cond - -for.end6: - ret void -} - -declare void @llvm.lifetime.start(ptr nocapture) - -declare void @llvm.memcpy.p0.p0.i64(ptr nocapture writeonly, ptr nocapture readonly, i64, i1) - -declare i32 @memcmp(ptr, ptr, i64) -declare i32 @bcmp(ptr, ptr, i64) - -declare void @llvm.lifetime.end(ptr nocapture) `````````` </details> https://github.com/llvm/llvm-project/pull/197615 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
