https://github.com/boomanaiden154 commented:
> I don't like this change: it assumes that lit is only used in LLVM contexts, > which is incorrect (lit can be used independently of LLVM). The options to > lit should be generally applicable. If a specific feature is needed for some > small subset of testing within LLVM, it would make more sense for that to be > something in the local config or similar. Agreed. I also commented in the base PR that I'm not sure this is very different than `llvm-extract` with a bit of syntactic sugar around it that I don't think buys us much for the additional code. https://github.com/llvm/llvm-project/pull/199391 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
