Thrrreeee wrote:
LGTM, I have tested it, and the RSS reduction is quite noticeable. But, from my
understanding, these changes don't seem to need to depend on
[#207291](https://github.com/llvm/llvm-project/pull/207291).
> // For split DWARF, preprocessDWODebugInfo already fully extracts the .dwo's
> // DIE array.
if (DIEUnit->isDWOUnit()) {
for (const DWARFDebugInfoEntry &Entry : DIEUnit->dies())
processScopeDie(DWARFDie(DIEUnit, &Entry));
continue;
}
The code here just consumes getNonSkeletonUnitDIE(false, xx), right? Maybe the
change here could be reworded to avoid causing confusion. Such as, first PR
#207292 and then #207291? Nothing critical, just a small nitpick :)
https://github.com/llvm/llvm-project/pull/207292
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
