github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h --
clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
clang/include/clang/Analysis/Analyses/LifetimeSafety/Loans.h
clang/lib/Analysis/LifetimeSafety/Facts.cpp
clang/lib/Analysis/LifetimeSafety/FactsGenerator.cpp
clang/lib/Analysis/LifetimeSafety/LoanPropagation.cpp
clang/lib/Analysis/LifetimeSafety/Loans.cpp
clang/test/Sema/LifetimeSafety/invalidations.cpp
clang/unittests/Analysis/LifetimeSafetyTest.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
b/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
index e871ca704..b4b965c2a 100644
--- a/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
+++ b/clang/include/clang/Analysis/Analyses/LifetimeSafety/Facts.h
@@ -150,7 +150,6 @@ class OriginFlowFact : public Fact {
/// `p = obj.field;` where `p` gets a loan to `obj.field`.
std::optional<PathElement> AddToPath;
-
public:
static bool classof(const Fact *F) {
return F->getKind() == Kind::OriginFlow;
@@ -166,7 +165,6 @@ public:
bool getKillDest() const { return KillDest; }
std::optional<PathElement> getPathElement() const { return AddToPath; }
-
void dump(llvm::raw_ostream &OS, const LoanManager &, const OriginManager
&OM,
const LoanPropagationAnalysis *LPA = nullptr) const override;
};
diff --git a/clang/include/clang/Analysis/Analyses/LifetimeSafety/Loans.h
b/clang/include/clang/Analysis/Analyses/LifetimeSafety/Loans.h
index c1da7d57a..14694ec02 100644
--- a/clang/include/clang/Analysis/Analyses/LifetimeSafety/Loans.h
+++ b/clang/include/clang/Analysis/Analyses/LifetimeSafety/Loans.h
@@ -213,7 +213,6 @@ public:
class LoanManager {
using ExtensionCacheKey = std::pair<LoanID, PathElement>;
-
public:
LoanManager() = default;
@@ -237,8 +236,6 @@ public:
llvm::SmallVector<LoanID, 2> getBaseLoans(LoanID ExtendedLoanID,
PathElement Element) const;
-
-
const Loan *getLoan(LoanID ID) const {
assert(ID.Value < AllLoans.size());
return AllLoans[ID.Value];
@@ -258,7 +255,6 @@ private:
/// analysis convergence.
llvm::DenseMap<ExtensionCacheKey, Loan *> ExtensionCache;
-
/// TODO(opt): Profile and evaluate the usefullness of small buffer
/// optimisation.
llvm::SmallVector<const Loan *> AllLoans;
@@ -278,5 +274,4 @@ template <> struct
DenseMapInfo<clang::lifetimes::internal::PathElement> {
};
} // namespace llvm
-
#endif // LLVM_CLANG_ANALYSIS_ANALYSES_LIFETIMESAFETY_LOANS_H
``````````
</details>
https://github.com/llvm/llvm-project/pull/207520
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
