[llvm-branch-commits] [lldb] [lldb][AArch64] Remove size from type detector entries (PR #214733)

[via llvm-branch-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: David Spickett (DavidSpickett)

<details>
<summary>Changes</summary>

This was passed to the constructor but goes unused.
The detector functions know the size of the type
they're creating already.

&lt;sub&gt;Stack created with &lt;a 
href="https://github.com/github/gh-stack"&gt;GitHub Stacks CLI&lt;/a&gt; • 
&lt;a href="https://gh.io/stacks-feedback"&gt;Give Feedback 
💬&lt;/a&gt;&lt;/sub&gt;

---
Full diff: https://github.com/llvm/llvm-project/pull/214733.diff


1 Files Affected:

- (modified) lldb/source/Plugins/Process/Utility/RegisterTypeDetector_arm64.h 
(+10-11) 


``````````diff
diff --git a/lldb/source/Plugins/Process/Utility/RegisterTypeDetector_arm64.h 
b/lldb/source/Plugins/Process/Utility/RegisterTypeDetector_arm64.h
index b27bff750c607..8907f7e669953 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterTypeDetector_arm64.h
+++ b/lldb/source/Plugins/Process/Utility/RegisterTypeDetector_arm64.h
@@ -75,7 +75,7 @@ class Arm64RegisterTypeDetector {
                                        uint64_t hwcap3);
 
   struct RegisterEntry {
-    RegisterEntry(llvm::StringRef name, unsigned size, DetectorFn detector)
+    RegisterEntry(llvm::StringRef name, DetectorFn detector)
         : m_name(name), m_type(nullptr), m_detector(detector) {}
 
     llvm::StringRef m_name;
@@ -84,18 +84,17 @@ class Arm64RegisterTypeDetector {
     const RegisterType *m_type;
     DetectorFn m_detector;
   } m_registers[9] = {
-      RegisterEntry("cpsr", 4, &Arm64RegisterTypeDetector::DetectCPSRType),
-      RegisterEntry("fpsr", 4, &Arm64RegisterTypeDetector::DetectFPSRType),
-      RegisterEntry("fpcr", 4, &Arm64RegisterTypeDetector::DetectFPCRType),
-      RegisterEntry("mte_ctrl", 8,
-                    &Arm64RegisterTypeDetector::DetectMTECtrlType),
-      RegisterEntry("svcr", 8, &Arm64RegisterTypeDetector::DetectSVCRType),
-      RegisterEntry("fpmr", 8, &Arm64RegisterTypeDetector::DetectFPMRType),
-      RegisterEntry("gcs_features_enabled", 8,
+      RegisterEntry("cpsr", &Arm64RegisterTypeDetector::DetectCPSRType),
+      RegisterEntry("fpsr", &Arm64RegisterTypeDetector::DetectFPSRType),
+      RegisterEntry("fpcr", &Arm64RegisterTypeDetector::DetectFPCRType),
+      RegisterEntry("mte_ctrl", &Arm64RegisterTypeDetector::DetectMTECtrlType),
+      RegisterEntry("svcr", &Arm64RegisterTypeDetector::DetectSVCRType),
+      RegisterEntry("fpmr", &Arm64RegisterTypeDetector::DetectFPMRType),
+      RegisterEntry("gcs_features_enabled",
                     &Arm64RegisterTypeDetector::DetectGCSFeaturesType),
-      RegisterEntry("gcs_features_locked", 8,
+      RegisterEntry("gcs_features_locked",
                     &Arm64RegisterTypeDetector::DetectGCSFeaturesType),
-      RegisterEntry("por_el0", 8, 
&Arm64RegisterTypeDetector::DetectPOREL0Type),
+      RegisterEntry("por_el0", &Arm64RegisterTypeDetector::DetectPOREL0Type),
   };
 
   // Becomes true once field detection has been run for all registers.

``````````

</details>


https://github.com/llvm/llvm-project/pull/214733
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits