================

----------------
rengolin wrote:

No, this change is required to allow the new builder to pass in 
`ElementwiseKind` instead of its attribute. This in turn is required to 
construct `linalg.elementwise` operations as easily as `linalg.*` named ones. 
There is one user upstream and likely more downstream.

This change is not completely independent from removing `linalg.select` because 
it's a cleaner solution than changing the affected upstream code to use weird 
syntax, and then shortly later update this. There are other similar cleanups 
that have been pushed to this PR from the other two in the stack for similar 
reasons.

The idea is that, at the end of this stack, the code is ready for anyone to use 
elementwise directly like they used to do with named ones. Yes, there are still 
some left over work (I created a number of issues for those), but we can make 
do without them in this PR.

https://github.com/llvm/llvm-project/pull/220916
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to