https://github.com/MixedMatched commented:
On a once-over, nothing jumped out at me as wrong, so I just have a few things that would be nice for posterity's sake: 1. llvm/docs/CommandGuide/llvm-offload-binary.md needs to be changed to include compression and version updates, and it might be nice to include in the tool section of ReleaseNotes. Not sure that needs to be included in this PR though. 2. It might be prudent to include a small LLVMFuzzerTestOneInput for extractOffloadBinaries to check what might result from adversarial or corrupted offload binary files. OTOH, I don't think those things necessarily have to be in the scope of what's being considered. https://github.com/llvm/llvm-project/pull/222774 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
