topperc wrote: > > I'm not sure I believe UADDO_CARRY/USUBO_CARRY don't conform to > > getBooleanContents. Type legalization uses PromoteIntRes_Overflow just like > > SADDO_CARRY/SSUBO_CARRY. This uses getBoolExtTrunc and PromoteTargetBoolean. > > I think the documentation in ISDOpcodes may be incorrect. > > Is this an issue that should block this change from consideration for the > release branch?
The patch is incorrect for targets the use ZeroOrNegativeOne boolean contents. We either need to consider boolean contents or we need to disable the combine for ZeroOrNegativeOne boolean contents. https://github.com/llvm/llvm-project/pull/223616 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
