adurang wrote: > Due to a mix of refactoring and changes, this feels a bit difficult to > review. I asked my agent to see how mechanic the changes are and it thinks > that there is an issue because prepareBlockMemory() has been moved from > GenericKernelTy::launch() to libompaccsupport/device.cpp, which is only > reachable from DeviceTy::launchKernel and not from olLaunchKernel_impl > anymore. Specifically, there seem to be two issues: > > > * StaticBlockMemSize > MaxBlockMemSize → INVALID_ARGUMENT > > * Fallback == Abort && Static + Dyn > MaxBlockMemSize → INVALID_ARGUMENT > > (liboffload never sets a fallback, so Abort == 0 always held there — this > > check always applied)
Thanks, after quickly checking I think these are valid issues. Let me address them. https://github.com/llvm/llvm-project/pull/223761 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
