pedroclobo wrote:

> This looks fine to me. I think it would also make it a bit easier to extend 
> to address #99268 and friends.

Thanks. I would look into it after merging this stack.

> Were you also considering adding support in ConstantFolding? Might make sense 
> to address this contextually before employing the new instructions (given, 
> also, that we still don't emit byte-typed IR), as GVN wouldn't otherwise 
> perform simple store to load forwards here 
> (https://llvm.godbolt.org/z/zn6o7Mcca).

> I'm not sure on the ordering of this change vs others introducing the new 
> instructions on byte type however.

I've implemented the constant folding changes for the new instructions.

https://github.com/llvm/llvm-project/pull/226583
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to