Author: Simon Pilgrim
Date: 2026-11-08T15:42:03+01:00
New Revision: a4ae88b0bdb55a124b3d76e4655088b5ead3c80f

URL: 
https://github.com/llvm/llvm-project/commit/a4ae88b0bdb55a124b3d76e4655088b5ead3c80f
DIFF: 
https://github.com/llvm/llvm-project/commit/a4ae88b0bdb55a124b3d76e4655088b5ead3c80f.diff

LOG: [X86] incDecVectorConstant - use ++/-- prefix operator to 
increment/decrement (#237176)

Don't just add immediate as it might not promote correctly to types
greater than 64-bits

Fixes #236021

(cherry picked from commit f64f3ea8f0f456790399fb50c7df368eafd26686)

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp
    llvm/test/CodeGen/X86/pr236021.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp 
b/llvm/lib/Target/X86/X86ISelLowering.cpp
index e4d4da09ce9b73..1d3b66ca27ab5f 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -24476,8 +24476,8 @@ static SDValue incDecVectorConstant(SDValue V, 
SelectionDAG &DAG, bool IsInc,
     if (NSW && ((IsInc && EltC.isMaxSignedValue()) ||
                 (!IsInc && EltC.isMinSignedValue())))
       return SDValue();
-
-    NewVecC.push_back(EltC + (IsInc ? 1 : -1));
+    APInt NewEltC = EltC;
+    NewVecC.push_back(IsInc ? ++NewEltC : --NewEltC);
   }
   return getConstVector(NewVecC, VT, DAG, SDLoc(V));
 }

diff  --git a/llvm/test/CodeGen/X86/pr236021.ll 
b/llvm/test/CodeGen/X86/pr236021.ll
index 5580a459d15f28..1e1db568409bca 100644
--- a/llvm/test/CodeGen/X86/pr236021.ll
+++ b/llvm/test/CodeGen/X86/pr236021.ll
@@ -12,7 +12,7 @@ define i32 @PR236021() {
 ; X86-NEXT:    cmpl x, %ecx
 ; X86-NEXT:    movl $0, %ecx
 ; X86-NEXT:    sbbl x+4, %ecx
-; X86-NEXT:    movl $1, %ecx
+; X86-NEXT:    movl $0, %ecx
 ; X86-NEXT:    sbbl x+8, %ecx
 ; X86-NEXT:    sbbl x+12, %eax
 ; X86-NEXT:    setge %al
@@ -22,9 +22,9 @@ define i32 @PR236021() {
 ; X64-LABEL: PR236021:
 ; X64:       # %bb.0:
 ; X64-NEXT:    movq x@GOTPCREL(%rip), %rax
-; X64-NEXT:    movl $63, %ecx
-; X64-NEXT:    cmpq (%rax), %rcx
-; X64-NEXT:    movl $1, %ecx
+; X64-NEXT:    xorl %ecx, %ecx
+; X64-NEXT:    movl $63, %edx
+; X64-NEXT:    cmpq (%rax), %rdx
 ; X64-NEXT:    sbbq 8(%rax), %rcx
 ; X64-NEXT:    setl %al
 ; X64-NEXT:    notb %al


        
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to