https://llvm.org/bugs/show_bug.cgi?id=27920

            Bug ID: 27920
           Summary: ToolChains.cpp: suspicious "const string" variables
           Product: clang
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P
         Component: Driver
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]
    Classification: Unclassified

I found the following line suspicious in the constructor Linux::Linux(...):

  const std::string OSLibDir = getOSLibDir(Triple, Args);

It seems OSLibDir is used to capture the return value of a function, thus
should be a const string reference rather than a const string. I guess the
original writer omitted the '&' symbol somehow.

The same type of issue appears a few times in this file and other files like
Tools.cpp.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to