Issue 240686
Summary [AArch64][PAuth] AArch64AsmPrinter::emitXXStructor Signs Legacy .ctors/.dtors Pointers Under -fptrauth-init-fini -fno-use-init-array Without Checking UseInitArray
Labels new issue
Assignees
Reporter zjy-dev
    In AArch64AsmPrinter::emitXXStructor (llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:1493-1521), whenever the module flag `"ptrauth-init-fini"` (`PtrauthInitFini`) is non-zero, `emitXXStructor` wraps the constructor/destructor function pointer in `ConstantPtrAuth::get(CV, InitFiniKey /*IA*/, 0xda04 /*55764*/, AddressDisc)` before delegating to `AsmPrinter::emitXXStructor(DL, CV)`. However, `AsmPrinter::emitXXStructor` emits into `.init_array`/`.fini_array` only when `TM.Options.UseInitArray` is true, and into legacy `.ctors`/`.dtors` when `-fno-use-init-array` (`!TM.Options.UseInitArray`) is specified. Under the AArch64 PAuth ABI specification and C runtime startup code (`__do_global_ctors_aux`), `ptrauth-init-fini` (`0xda04` address-discriminated IA signing) applies exclusively to `.init_array`/`.fini_array`, while `.ctors`/`.dtors` walkers invoke raw function pointers without `autia` authentication with discriminator `55764`.

### Reproducer (`trigger.c`)

```c
volatile int sink;

__attribute__((constructor(101))) static void ctor_prio(void) { sink = 1; }
__attribute__((constructor)) static void ctor_default(void) { sink = 2; }
__attribute__((destructor)) static void dtor_default(void) { sink = 3; }

int main(void) { return sink; }
```

Compile / reproduction command (`['--target=aarch64-unknown-linux-pauthtest', '-fptrauth-init-fini', '-fno-use-init-array', '-O2', '-S']`):

```bash
podman exec -i -e TMPDIR=/dev/shm defuzz-toolchain-daemon /opt/llvm23/bin/clang --target=aarch64-unknown-linux-pauthtest -fptrauth-init-fini -fno-use-init-array -O2 -x c - -S -o -
```

Observed output on LLVM 23.1.2:

```text
.section	.ctors,"aw",@progbits
	.p2align	3, 0x0
	.xword	ctor_default@AUTH(ia,55764,addr)
	.section	.ctors.65434,"aw",@progbits
	.p2align	3, 0x0
	.xword	ctor_prio@AUTH(ia,55764,addr)
	.section	.dtors,"aw",@progbits
	.p2align	3, 0x0
	.xword	dtor_default@AUTH(ia,55764,addr)
```

### Expected behavior

`AArch64AsmPrinter::emitXXStructor` (or the Clang driver) should either guard `if (PtrauthInitFini && TM.Options.UseInitArray)` or diagnose `-fptrauth-init-fini` as incompatible with `-fno-use-init-array`.

### Root cause & impact

- **Source location**: `llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:1493-1521`
- **Impact**: Emits `R_AARCH64_AUTH_ABS64` signed pointers with discriminator `55764` (`0xda04`) into legacy `.ctors`/`.dtors` sections under `-fptrauth-init-fini -fno-use-init-array`, causing startup crash when `.ctors` is walked without `0xda04` pointer authentication.

### Suggested fix

In `AArch64AsmPrinter::emitXXStructor` (`AArch64AsmPrinter.cpp:1499`), check `if (PtrauthInitFini && TM.Options.UseInitArray)` (and/or reject `-fptrauth-init-fini` with `-fno-use-init-array` in the Clang driver).

Environment: LLVM 23.1.2 (`llvmorg-23.1.2`), affected targets: `aarch64`.

_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to