Issue 240901
Summary [LoopIdiomRecognize] Miscompilation on strlen idiom
Labels new issue
Assignees
Reporter mikekben
    The following program miscompiles when loop idiom recognition is applied:
```
target triple = "x86_64-unknown-linux-gnu"

define i64 @f(ptr noundef %s, i64 noundef %n) {
entry:
  br label %outer

outer: ; preds = %outer.latch, %entry
  %j = phi i64 [ 0, %entry ], [ %j.next, %outer.latch ]
  br label %inner

inner: ; preds = %inner, %outer
  %p = phi ptr [ %s, %outer ], [ %p.next, %inner ]
  %q = phi i64 [ %j, %outer ], [ %q.next, %inner ]
  %q.next = add i64 %q, 0
  %p.next = getelementptr i8, ptr %p, i64 1
  %c = load i8, ptr %p, align 1
  %nz = icmp ne i8 %c, 0
  br i1 %nz, label %inner, label %outer.latch

outer.latch:                                      ; preds = %inner
  %j.next = add i64 %j, 1
  %done = icmp eq i64 %j, 1
  br i1 %done, label %exit, label %outer

exit: ; preds = %outer.latch
  ret i64 %q
}

@a = global [1 x i8] zeroinitializer
@fmt = private constant [5 x i8] c"%ld\0A\00"

declare i32 @printf(ptr, ...)

define i32 @main() {
  %r = call i64 @f(ptr @a, i64 2)
  %1 = call i32 (ptr, ...) @printf(ptr @fmt, i64 %r)
  ret i32 0
}
```

```
$ clang -O0 reduced.ll -o ref ; ./ref
> 1
$ opt -passes=loop-idiom -S -o reduced_opt.ll ; clang -O0 reduced_opt.ll -o opt ; ./opt
> 0
```

Program reduced with llvm-reduce and tested on recent LLVM commit `98407454f4a9727c1327158626141654bd3df8fd`. Based on a preliminary investigation, this appears to be a bug in the idiom replacing strlen.
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to