https://llvm.org/bugs/show_bug.cgi?id=31753
Bug ID: 31753
Summary: llvm/lib/CodeGen/MachinePipeliner.cpp: 2 * pointless
tests
Product: new-bugs
Version: trunk
Hardware: PC
OS: Linux
Status: NEW
Severity: enhancement
Priority: P
Component: new bugs
Assignee: unassignedb...@nondot.org
Reporter: dcb...@hotmail.com
CC: llvm-bugs@lists.llvm.org
Classification: Unclassified
1.
lvm/lib/CodeGen/MachinePipeliner.cpp:963]: (style) Condition
'Phi.getOperand(i+1).getMBB()==Loop' is always true
Source code is
for (unsigned i = 1, e = Phi.getNumOperands(); i != e; i += 2)
if (Phi.getOperand(i + 1).getMBB() != Loop)
InitVal = Phi.getOperand(i).getReg();
else if (Phi.getOperand(i + 1).getMBB() == Loop)
LoopVal = Phi.getOperand(i).getReg();
Suggest new code
for (unsigned i = 1, e = Phi.getNumOperands(); i != e; i += 2)
if (Phi.getOperand(i + 1).getMBB() != Loop)
InitVal = Phi.getOperand(i).getReg();
else
LoopVal = Phi.getOperand(i).getReg();
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
