https://bugs.llvm.org/show_bug.cgi?id=37484

            Bug ID: 37484
           Summary: src/experimental/filesystem/directory_iterator.cpp:98:
                    suspicious call to strcmp
           Product: libc++
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: All Bugs
          Assignee: unassignedclangb...@nondot.org
          Reporter: dcb...@hotmail.com
                CC: llvm-bugs@lists.llvm.org, mclow.li...@gmail.com

libcxx/src/experimental/filesystem/directory_iterator.cpp:98]: (warning) The
expression 'strcmp(__data_.cFileName,"..") != 0' is suspicious. It overlaps
'!strcmp(__data_.cFileName,".")'.

Source code is

  if (!strcmp(__data_.cFileName, ".") || strcmp(__data_.cFileName, ".."))
        continue;

Maybe better code

  if (strcmp(__data_.cFileName, ".") == 0 || strcmp(__data_.cFileName, "..") ==
0)
        continue;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to