https://bugs.llvm.org/show_bug.cgi?id=41488

            Bug ID: 41488
           Summary: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:
                    225: suspicious test ?
           Product: new-bugs
           Version: trunk
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P
         Component: new bugs
          Assignee: unassignedb...@nondot.org
          Reporter: dcb...@hotmail.com
                CC: htmldevelo...@gmail.com, llvm-bugs@lists.llvm.org

llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:225]: (style) Same
expression on both sides of '||'.

Source code is

  if (TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers) ||
      TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers))

Maybe better code

  if (TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers) ||
      TII->hasModifiersSet(*Sel, AMDGPU::OpName::src1_modifiers))

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to