| Issue |
124149
|
| Summary |
[libc] clean up duplicated includes in generated headers
|
| Labels |
good first issue,
libc
|
| Assignees |
|
| Reporter |
nickdesaulniers
|
After doing a full build, the generated wchar.h header has:
```c
#include "__llvm-libc-common.h"
#include "llvm-libc-macros/wchar-macros.h"
#include "llvm-libc-types/wint_t.h"
#include "llvm-libc-types/mbstate_t.h"
#include <llvm-libc-types/mbstate_t.h>
#include <llvm-libc-types/size_t.h>
#include <llvm-libc-types/wchar_t.h>
#include <llvm-libc-types/wint_t.h>
```
This is because we list the dependencies in libc/include/wchar.h.def AND libc/include/wchar.yaml. With the move to newhdrgen, we no longer need to list these includes manually in libc/include/*.h.def files; we should encode these in libc/include/*.yaml instead.
At the very least, libc/include/wchar.h.def should be cleaned up, but perhaps there's more duplication like this going on, too. Note: you'll need to do a fullbuild to generate the headers.
https://libc.llvm.org/full_host_build.html
`-DLLVM_LIBC_FULL_BUILD=ON` should be set in your cmake.
![]()
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
