| Issue |
154760
|
| Summary |
Clang-tidy invalid suggestion: misc-use-internal-linkage
|
| Labels |
clang-tidy
|
| Assignees |
|
| Reporter |
joker-eph
|
With clang-tidy built at current head and applying it on MLIR:
```
$ clang-tidy -p build mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp --checks=-*,misc-use-internal-linkage -fix -fix-errors
```
diff --git a/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp b/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp
index 1787e0a44f8f..50a93dec9446 100644
--- a/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp
+++ b/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp
@@ -485,8 +485,8 @@ struct RoundOpPattern final : public OpConversionPattern<math::RoundOp> {
//===----------------------------------------------------------------------===//
namespace mlir {
-void populateMathToSPIRVPatterns(const SPIRVTypeConverter &typeConverter,
- RewritePatternSet &patterns) {
+static void populateMathToSPIRVPatterns(const SPIRVTypeConverter &typeConverter,
+ RewritePatternSet &patterns) {
// Core patterns
patterns
.add<CopySignPattern,
```
Yields a build failure:
```
>>> referenced by MathToSPIRVPass.cpp
>>> MathToSPIRVPass.cpp.o:((anonymous namespace)::ConvertMathToSPIRVPass::runOnOperation()) in archive lib/libMLIRMathToSPIRV.a
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
```
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
