| Issue |
154957
|
| Summary |
clang-tidy suggests CamelCase for a single variable (when the config is camelBack)
|
| Labels |
clang-tidy
|
| Assignees |
|
| Reporter |
joker-eph
|
With clang-tidy freshly built:
```
bin/clang-tidy -p build mlir/lib/Analysis/FlatLinearValueConstraints.cpp --checks=-*,readability-identifier-naming
```
```
2397 warnings generated.
mlir/lib/Analysis/FlatLinearValueConstraints.cpp:1306:38: warning: invalid case style for parameter 'var' [readability-identifier-naming]
1306 | [](const std::optional<Value> &var) { return var.has_value(); }));
| ^~~ ~~~
| Var Var
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
93 | (static_cast <bool> (expr) \
| ^
mlir/lib/Analysis/FlatLinearValueConstraints.cpp:1310:38: warning: invalid case style for parameter 'var' [readability-identifier-naming]
1310 | [](const std::optional<Value> &var) { return var.has_value(); }));
| ^~~ ~~~
| Var Var
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
93 | (static_cast <bool> (expr) \
| ^
Suppressed 2401 warnings (2395 in non-user code, 6 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
```
But see the surrounding code, it's all `camelBack`:
```
static void mergeAndAlignVars(unsigned offset, FlatLinearValueConstraints *a,
FlatLinearValueConstraints *b) {
assert(offset <= a->getNumDimVars() && offset <= b->getNumDimVars());
assert(llvm::all_of(
llvm::drop_begin(a->getMaybeValues(), offset),
[](const std::optional<Value> &var) { return var.has_value(); }));
assert(llvm::all_of(
llvm::drop_begin(b->getMaybeValues(), offset),
[](const std::optional<Value> &var) { return var.has_value(); }));
SmallVector<Value, 4> aDimValues;
a->getValues(offset, a->getNumDimVars(), &aDimValues);
```
I don't know why the callback here was singled out?
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
